Feature/extensibility enhancements #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Nest/Domain/ICustomJson.cs
Outdated
Member
There was a problem hiding this comment.
lets make this a proper <summary>: Any object that implements this interface will automatically have all the JsonProperties of all its implementing interfaces discovered.
gmarz
added a commit
that referenced
this pull request
May 27, 2015
Feature/extensibility enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElasticClientnow implementsIHighLevelToLowLevelDispatcherexplicitly so the internal-ish dispatch methods are less exposed. This required casting toIHighLevelToLowLevelDispatcherin order to access the dispatch methods, so I added an internalDispatcher { get { return this; } }convenience property (much like we do withSelfin the descriptors).IDomainObjectto the more descriptiveINestSerializable.CloneFrom()back to internal since it doesn't need to be exposed.